PHP7 depreciated constructor (v2.14)

by R00KIE, Wednesday, January 06, 2016, 19:38 (3200 days ago) @ nickrickard
edited by R00KIE, Wednesday, January 06, 2016, 19:55

I've just tried the current git version and it also fails to update some feeds.

I still get the "Error Methods with the same name as their class will not be constructors in a future version of PHP; floIcon has a deprecated constructor" message.

This is an error and once you it this all further processing stops. It seems selfoss will later try other feeds so I suppose it will skip the "offending" feeds and still manage to update the ones that don't cause problems.

Example log:

### I've triggered an update via the web interface by clicking the update button

01-06-16 18:31:00 Debug Establish database connection
01-06-16 18:31:44 Debug Establish database connection
01-06-16 18:31:54 Debug ---
01-06-16 18:31:54 Debug start fetching source "Hackaday (id: 32)
01-06-16 18:31:54 Debug spout successfully loaded: spouts\rss\feed
01-06-16 18:31:54 Debug fetch content
01-06-16 18:31:55 Debug minimum date: 2015-10-08 18:31:55
01-06-16 18:31:55 Debug start item fetching
01-06-16 18:31:55 Debug start insertion of new item "The Most Plausible Apollo Moon Landing Conspiracy Ever Devised"
01-06-16 18:31:56 Debug item content sanitized
01-06-16 18:31:57 Error Methods with the same name as their class will not be constructors in a future version of PHP; floIcon has a deprecated constructor

### It stopped here with a popup saying: "Can not refresh sources: Internal Server Error", then I've triggered another update and it seems to continue until it hits another problematic feed (not shown).

01-06-16 18:34:22 Debug Establish database connection
01-06-16 18:34:28 Debug ---
01-06-16 18:34:28 Debug start fetching source "LWN.net (id: 33)
01-06-16 18:34:28 Debug spout successfully loaded: spouts\rss\feed
01-06-16 18:34:28 Debug fetch content
01-06-16 18:34:29 Debug minimum date: 2015-10-08 18:34:29
01-06-16 18:34:29 Debug start item fetching
01-06-16 18:34:29 Debug start insertion of new item "Security updates for Wednesday"
01-06-16 18:34:29 Debug item content sanitized
01-06-16 18:34:30 Debug icon: using feed homepage favicon: http://lwn.net/images/favicon.png
01-06-16 18:34:31 Debug icon generated: http://lwn.net/images/favicon.png
01-06-16 18:34:34 Debug item inserted
01-06-16 18:34:34 Debug Memory usage: 4099600
01-06-16 18:34:34 Debug Memory peak usage: 5399000
01-06-16 18:34:34 Debug destroy spout object
01-06-16 18:34:39 Debug ---

I guess it's time to take to take a trip to the bug tracker.